227 lines
11 KiB
Python
227 lines
11 KiB
Python
"""Repository behaviour on SQLite and, when TEST_PG_DSN is set, on PostgreSQL."""
|
|
import asyncio
|
|
from datetime import UTC
|
|
|
|
import pytest
|
|
|
|
from estimator.config.sections import DatabaseCfg
|
|
from estimator.domain.enums import Region
|
|
from estimator.domain.errors import EstimateNotFound, IdempotencyConflict, InvalidRequestError
|
|
from estimator.domain.estimates import EstimateStatus, NewVersion, VersionSource
|
|
from estimator.domain.models import AnsweredQuestion
|
|
from estimator.infra.db import SqlEstimateRepo, make_engine, make_session_factory
|
|
|
|
|
|
@pytest.fixture
|
|
async def repo(backend_dsn):
|
|
engine = make_engine(DatabaseCfg(dsn=backend_dsn))
|
|
yield SqlEstimateRepo(make_session_factory(engine))
|
|
await engine.dispose()
|
|
|
|
|
|
def new(text="бот", **kw) -> NewVersion:
|
|
return NewVersion(requirements=text, region=Region.RU, currency="RUB", **kw)
|
|
|
|
|
|
async def test_create_and_get_roundtrip(repo):
|
|
data = new(
|
|
"бот для Telegram",
|
|
answers=[AnsweredQuestion(question="CRM?", answer="amoCRM")],
|
|
proceed_with_assumptions=True,
|
|
)
|
|
eid, version, created = await repo.create(client="a", idempotency_key=None, request_hash="h", data=data)
|
|
assert created and version == 1
|
|
rec = await repo.get("a", eid)
|
|
assert rec.requirements == "бот для Telegram" and rec.status == EstimateStatus.PENDING
|
|
assert rec.answers == [AnsweredQuestion(question="CRM?", answer="amoCRM")]
|
|
assert rec.proceed_with_assumptions and rec.region == Region.RU
|
|
assert rec.created_at.tzinfo is not None and rec.created_at.utcoffset().total_seconds() == 0
|
|
assert rec.latest_version == 1 and rec.estimate_created_at == rec.created_at
|
|
|
|
|
|
async def test_other_client_cannot_read_or_extend(repo):
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
with pytest.raises(EstimateNotFound):
|
|
await repo.get("b", eid)
|
|
with pytest.raises(EstimateNotFound):
|
|
await repo.add_version(client="b", estimate_id=eid, data=new())
|
|
with pytest.raises(EstimateNotFound):
|
|
await repo.get("a", "does-not-exist")
|
|
|
|
|
|
async def test_idempotency_same_request_returns_original(repo):
|
|
a = await repo.create(client="a", idempotency_key="k1", request_hash="h", data=new())
|
|
b = await repo.create(client="a", idempotency_key="k1", request_hash="h", data=new())
|
|
assert a[0] == b[0] and a[2] is True and b[2] is False
|
|
|
|
|
|
async def test_idempotency_different_request_conflicts(repo):
|
|
await repo.create(client="a", idempotency_key="k1", request_hash="h1", data=new())
|
|
with pytest.raises(IdempotencyConflict):
|
|
await repo.create(client="a", idempotency_key="k1", request_hash="h2", data=new())
|
|
|
|
|
|
async def test_idempotency_key_is_per_client(repo):
|
|
a = await repo.create(client="a", idempotency_key="k1", request_hash="h", data=new())
|
|
b = await repo.create(client="b", idempotency_key="k1", request_hash="h", data=new())
|
|
assert a[0] != b[0] and a[2] and b[2]
|
|
|
|
|
|
async def test_idempotency_race_creates_one_estimate(repo):
|
|
results = await asyncio.gather(
|
|
*[repo.create(client="a", idempotency_key="race", request_hash="h", data=new()) for _ in range(6)]
|
|
)
|
|
assert len({r[0] for r in results}) == 1
|
|
assert sum(1 for r in results if r[2]) == 1
|
|
|
|
|
|
async def test_without_key_every_create_is_new(repo):
|
|
a = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
b = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
assert a[0] != b[0]
|
|
|
|
|
|
async def test_add_version_increments_and_keeps_history(repo):
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new("v1 text"))
|
|
v2 = await repo.add_version(
|
|
client="a", estimate_id=eid, data=new("v2 text", source=VersionSource.RECALC)
|
|
)
|
|
assert v2 == 2
|
|
assert (await repo.get("a", eid)).requirements == "v2 text" # latest by default
|
|
assert (await repo.get("a", eid, 1)).requirements == "v1 text" # history is kept
|
|
assert (await repo.get("a", eid, 2)).latest_version == 2
|
|
with pytest.raises(EstimateNotFound):
|
|
await repo.get("a", eid, 9)
|
|
|
|
|
|
async def test_concurrent_add_version_gets_distinct_numbers(repo):
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
numbers = await asyncio.gather(
|
|
*[repo.add_version(client="a", estimate_id=eid, data=new(f"t{i}")) for i in range(8)]
|
|
)
|
|
assert sorted(numbers) == list(range(2, 10))
|
|
assert (await repo.get("a", eid)).latest_version == 9
|
|
|
|
|
|
async def test_update_version_stores_json_and_times(repo):
|
|
from estimator.infra.db.types import utcnow
|
|
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
now = utcnow()
|
|
await repo.update_version(
|
|
eid, 1,
|
|
status="done", step=None, market_version="2026Q4",
|
|
result={"summary": "итог", "tasks": [{"id": "t1", "hours": 1.5}], "ключ": "значение"},
|
|
price={"cost_with_reserve": 370000.0}, finished_at=now,
|
|
) # fmt: skip
|
|
rec = await repo.get_by_id(eid, 1)
|
|
assert rec.status == EstimateStatus.DONE
|
|
assert rec.result["tasks"][0]["hours"] == 1.5 and rec.result["ключ"] == "значение"
|
|
assert rec.price == {"cost_with_reserve": 370000.0}
|
|
assert rec.finished_at.tzinfo is not None and abs((rec.finished_at - now).total_seconds()) < 1
|
|
assert rec.finished_at.tzinfo == UTC or rec.finished_at.utcoffset().total_seconds() == 0
|
|
|
|
|
|
async def test_update_version_rejects_immutable_fields(repo):
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
with pytest.raises(ValueError):
|
|
await repo.update_version(eid, 1, requirements="changed")
|
|
with pytest.raises(ValueError):
|
|
await repo.update_version(eid, 1, client="evil")
|
|
|
|
|
|
async def test_list_pages_newest_first_without_gaps_or_repeats(repo):
|
|
ids = []
|
|
for i in range(5):
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new(f"n{i}"))
|
|
ids.append(eid)
|
|
await repo.create(client="other", idempotency_key=None, request_hash="h", data=new("foreign"))
|
|
|
|
seen, cursor, pages = [], None, 0
|
|
while True:
|
|
page = await repo.list_page("a", status=None, limit=2, cursor=cursor)
|
|
seen += [i.id for i in page.items]
|
|
pages += 1
|
|
cursor = page.next_cursor
|
|
if not cursor:
|
|
break
|
|
assert pages == 3 and seen == list(reversed(ids))
|
|
|
|
|
|
async def test_list_exact_page_has_no_dangling_cursor(repo):
|
|
for i in range(2):
|
|
await repo.create(client="a", idempotency_key=None, request_hash="h", data=new(f"n{i}"))
|
|
page = await repo.list_page("a", status=None, limit=2, cursor=None)
|
|
assert len(page.items) == 2 and page.next_cursor is None
|
|
|
|
|
|
async def test_list_shows_latest_version_and_filters_by_status(repo):
|
|
e1, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new("one"))
|
|
e2, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new("two"))
|
|
await repo.update_version(
|
|
e1, 1, status="done", result={"summary": "Готово"}, price={"cost_with_reserve": 123000.0, "cost_expected": 100000.0}
|
|
)
|
|
await repo.add_version(client="a", estimate_id=e2, data=new("two again", status=EstimateStatus.NEEDS_INPUT))
|
|
|
|
done = await repo.list_page("a", status=EstimateStatus.DONE, limit=10, cursor=None)
|
|
assert [i.id for i in done.items] == [e1]
|
|
assert done.items[0].summary == "Готово" and done.items[0].cost == 123000.0
|
|
waiting = await repo.list_page("a", status=EstimateStatus.NEEDS_INPUT, limit=10, cursor=None)
|
|
assert [(i.id, i.version) for i in waiting.items] == [(e2, 2)] # filter looks at the latest version
|
|
|
|
|
|
async def test_invalid_cursor(repo):
|
|
with pytest.raises(InvalidRequestError):
|
|
await repo.list_page("a", status=None, limit=5, cursor="not-a-cursor")
|
|
|
|
|
|
async def test_active_versions_for_recovery(repo):
|
|
e1, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
e2, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
e3, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
await repo.update_version(e2, 1, status="running")
|
|
await repo.update_version(e3, 1, status="done")
|
|
active = await repo.active_versions()
|
|
assert {(i, v, s.value) for i, v, s in active} == {(e1, 1, "pending"), (e2, 1, "running")}
|
|
|
|
|
|
async def test_engagement_is_stored_per_version_and_defaults_to_fixed_price(repo):
|
|
from estimator.domain.enums import Engagement
|
|
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
assert (await repo.get("a", eid)).engagement == Engagement.FIXED_PRICE
|
|
v2 = await repo.add_version(
|
|
client="a", estimate_id=eid,
|
|
data=new(engagement=Engagement.TIME_AND_MATERIALS, source=VersionSource.REPRICE),
|
|
) # fmt: skip
|
|
assert (await repo.get("a", eid, v2)).engagement == Engagement.TIME_AND_MATERIALS
|
|
assert (await repo.get("a", eid, 1)).engagement == Engagement.FIXED_PRICE
|
|
assert (await repo.get("a", eid, v2)).source == VersionSource.REPRICE
|
|
|
|
|
|
async def test_list_amount_follows_the_engagement_model(repo):
|
|
from estimator.domain.enums import Engagement
|
|
|
|
price = {"cost_with_reserve": 370000.0, "cost_expected": 336000.0}
|
|
fixed, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new("fp"))
|
|
tm, *_ = await repo.create(
|
|
client="a", idempotency_key=None, request_hash="h",
|
|
data=new("tm", engagement=Engagement.TIME_AND_MATERIALS),
|
|
) # fmt: skip
|
|
await repo.update_version(fixed, 1, status="done", price=price)
|
|
await repo.update_version(tm, 1, status="done", price=price)
|
|
items = {i.id: i for i in (await repo.list_page("a", status=None, limit=10, cursor=None)).items}
|
|
assert items[fixed].cost == 370000.0 and items[fixed].engagement == Engagement.FIXED_PRICE
|
|
assert items[tm].cost == 336000.0 and items[tm].engagement == Engagement.TIME_AND_MATERIALS
|
|
|
|
|
|
async def test_vat_rate_is_stored_per_version(repo):
|
|
eid, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new(vat_rate=0.22))
|
|
assert (await repo.get("a", eid)).vat_rate == pytest.approx(0.22)
|
|
v2 = await repo.add_version(client="a", estimate_id=eid, data=new(vat_rate=0.0))
|
|
assert (await repo.get("a", eid, v2)).vat_rate == 0.0
|
|
assert (await repo.get("a", eid, 1)).vat_rate == pytest.approx(0.22)
|
|
other, *_ = await repo.create(client="a", idempotency_key=None, request_hash="h", data=new())
|
|
assert (await repo.get("a", other)).vat_rate == 0.0 # the default of a version is no VAT
|
|
|