Make editor updates asynchronous with unified preview API

This commit is contained in:
2026-11-13 15:18:56 +03:00
parent 0d171915d7
commit 3562194d92
30 changed files with 2445 additions and 748 deletions
+338
View File
@@ -0,0 +1,338 @@
"""Background editor acceptance in real Chromium, with isolated sites and delayed responses."""
from __future__ import annotations
import asyncio
import json
import os
import re
import shutil
import socket
import tempfile
import time
from contextlib import ExitStack
from pathlib import Path
from unittest.mock import patch
from playwright.sync_api import expect, sync_playwright
from qa_001 import PASSWORD, ROOT, serve
from site_engine.services.auth import hash_password
from site_engine.services.preview import PreviewStore
from site_engine.web.app import create_app
from site_engine.web.preview_app import create_preview_app
def reserve():
sock = socket.socket()
sock.bind(("127.0.0.1", 0))
return sock
def idle(page):
page.wait_for_function("""()=>{const e=document.getElementById('document-editor'),p=document.getElementById('preview-result');return e?.dataset.updating==='false'&&p?.dataset.ready==='true'&&p.dataset.revision===e.dataset.revision}""", timeout=25000)
def tree(page, identity):
page.locator(f'[data-tree-scope=page][data-tree-id="{identity}"]').click()
def title(page):
return page.locator('[data-inspector-panel=props] [name="p.title"]')
def heading(page, identity="hero_home"):
return page.frame_locator('#preview-result iframe').locator(f'[data-preview-id="{identity}"] h1, [data-preview-id="{identity}"] h2').first
def main():
out = Path(os.environ.get("QA_EDITOR_UPDATES_OUT", "/tmp/site-engine-editor-updates"))
out.mkdir(parents=True, exist_ok=True)
report = {"runs": [], "page_errors": [], "native_dialogs": []}
with sync_playwright() as pw:
browser = pw.chromium.launch(channel="chromium", headless=True, args=["--no-sandbox", "--no-proxy-server"])
for interactive in (False, True):
run = {"interactive": interactive, "checks": []}
report["runs"].append(run)
with tempfile.TemporaryDirectory(prefix="editor-updates-qa-") as temp, ExitStack() as stack:
work = Path(temp)
site = work / "site"
shutil.copytree(ROOT / "examples/site-studio", site)
original = (site / "pages/index.md").read_bytes()
admin_socket, preview_socket = reserve(), reserve()
admin = f"http://127.0.0.1:{admin_socket.getsockname()[1]}"
preview = f"http://127.0.0.1:{preview_socket.getsockname()[1]}"
stack.enter_context(patch.dict(os.environ, {
"SITE_ROOT": str(site), "SITE_DIST": str(work / "dist"),
"SITE_STATE_DIR": str(work / "state"), "SITE_ADMIN_LOGIN": "admin",
"SITE_ADMIN_PASSWORD_HASH": hash_password(PASSWORD, n=2**10),
"SITE_SECRET_KEY": "editor-background-browser-secret-" * 3,
"SITE_COOKIE_SECURE": "0", "SITE_ADMIN_ORIGIN": admin if interactive else "",
"SITE_PREVIEW_ORIGIN": preview if interactive else "",
}))
app = create_app()
gate = {"delay": 0, "save_delay": 0, "saving": False, "active": 0, "max_active": 0}
@app.middleware("http")
async def delays(request, call_next, gate=gate):
update = request.url.path.startswith('/admin/editor/') and request.url.path.endswith('/update')
save = request.url.path.startswith('/admin/editor/') and request.url.path.endswith('/save')
if update:
gate['active'] += 1
gate['max_active'] = max(gate['max_active'], gate['active'])
try:
if update and gate['delay']:
delay, gate['delay'] = gate['delay'], 0
await asyncio.sleep(delay)
if save and gate['save_delay']:
gate['saving'] = True
await asyncio.sleep(gate['save_delay'])
gate['saving'] = False
return await call_next(request)
finally:
if update:
gate['active'] -= 1
stack.enter_context(serve(app, admin_socket))
if interactive:
stack.enter_context(serve(create_preview_app(), preview_socket))
else:
preview_socket.close()
context = browser.new_context(viewport={"width": 1440, "height": 1050})
stack.callback(context.close)
page = context.new_page()
page.on('pageerror', lambda e: report['page_errors'].append(e.stack))
page.on('dialog', lambda d: (report['native_dialogs'].append(d.message), d.dismiss()))
posts = []
page.on('request', lambda r, posts=posts: posts.append(r.url) if r.method == 'POST' else None)
page.goto(admin + '/admin/login')
page.locator('[name=login]').fill('admin')
page.locator('[name=password]').fill(PASSWORD)
page.get_by_role('button', name='Войти', exact=True).click()
page.goto(admin + '/admin/pages/index')
idle(page)
page.locator('#preview-result iframe').evaluate('e=>e.__qaFrame=true')
page.frame_locator('#preview-result iframe').locator('body').evaluate('e=>e.ownerDocument.__qaDocument=true')
field = title(page)
field.evaluate('e=>e.__qaField=true')
before = len(posts)
page.evaluate("""()=>{window.__updateTiming={};document.addEventListener('input',()=>{window.__updateTiming.start=performance.now()},{once:true});const box=document.getElementById('preview-result');new MutationObserver(()=>{if(box.dataset.revision===document.getElementById('document-editor').dataset.revision&&box.dataset.ready==='true'&&window.__updateTiming.start&&!window.__updateTiming.ms)window.__updateTiming.ms=performance.now()-window.__updateTiming.start}).observe(box,{attributes:true})}""")
start = time.perf_counter()
field.fill('Single background update')
expect(heading(page)).to_have_text('Single background update')
idle(page)
run['input_to_preview_ms'] = round(page.evaluate('window.__updateTiming.ms'),1)
run['playwright_observation_ms'] = round((time.perf_counter() - start) * 1000, 1)
assert posts[before:] == [admin + '/admin/editor/pages/index/update'], posts[before:]
assert title(page).evaluate('e=>e.__qaField===true')
assert page.locator('#preview-result iframe').evaluate('e=>e.__qaFrame===true')
assert page.frame_locator('#preview-result iframe').locator('body').evaluate('e=>e.ownerDocument.__qaDocument===true')
run['checks'].append('one_post_preserves_input_frame_and_document')
# Filling the trailing blank list row must offer another row
# without replacing the active link input or its caret.
action = page.locator('[data-inspector] [name="p.actions.1.target"]')
action.evaluate('e=>e.__qaListInput=true')
action.fill('contacts')
expect(page.locator('[data-inspector] [name="p.actions.2.target"]')).to_be_visible()
idle(page)
assert action.evaluate('e=>e.__qaListInput===true&&document.activeElement===e')
action.press('End')
action.press_sequentially('#contact', delay=5)
idle(page)
expect(action).to_have_value('contacts#contact')
delete = page.locator('[data-inspector] [name="p.actions.1._del"]')
gate['delay'] = 1
delete.check()
page.wait_for_function("()=>document.getElementById('document-editor').dataset.updating==='true'")
title(page).fill('Typing while deleting list row')
idle(page)
expect(title(page)).to_have_value('Typing while deleting list row')
expect(page.locator('[data-inspector] [name="p.actions.0.target"]')).to_have_value('request')
expect(page.locator('[data-inspector] [name="p.actions.1.target"]')).to_have_value('')
assert page.locator('[data-inspector] [name="p.actions.2.target"]').count() == 0
run['checks'].append('list_append_preserves_active_input_and_delete_reindexes')
render_document = PreviewStore.render_document
def unsafe_markup(store, *args, _render_document=render_document, **kwargs):
value = _render_document(store, *args, **kwargs)
value['html'] = value['html'].replace('</body>', '<script nonce="untrusted">window.__qaUntrusted=true</script><svg onload="window.__qaUntrusted=true"></svg></body>')
return value
with patch.object(PreviewStore, 'render_document', unsafe_markup):
title(page).fill('Safe live markup update')
idle(page)
assert page.frame_locator('#preview-result iframe').locator('body').evaluate('e=>!e.ownerDocument.defaultView.__qaUntrusted&&!e.ownerDocument.querySelector("script,[onload],[nonce]")')
if interactive:
page.evaluate("""()=>{const frame=document.querySelector('#preview-result iframe'),root=document.getElementById('document-editor');frame.contentWindow.postMessage({type:'editor:render',snapshot:'0'.repeat(32),revision:Number(root.dataset.revision),next:{snapshot:'a'.repeat(32),revision:Number(root.dataset.revision)+1,html:'<html><body>FORGED UPDATE</body></html>'}},root.dataset.previewOrigin)}""")
page.wait_for_timeout(100)
expect(heading(page)).to_have_text('Safe live markup update')
run['checks'].append('hot_markup_strips_public_scripts_and_bridge_rejects_wrong_snapshot')
gate['delay'] = 2
field.fill('Delayed title')
page.wait_for_function("()=>document.getElementById('document-editor').dataset.updating==='true'")
assert not field.evaluate('e=>!!e.closest("[inert]")')
start = time.perf_counter()
field.press('End')
field.press_sequentially(' while typing', delay=5)
assert time.perf_counter() - start < 1
tree(page, 'services_list')
title(page).fill('Services while waiting')
tree(page, 'hero_home')
expect(title(page)).to_have_value('Delayed title while typing')
title(page).press('End')
title(page).press_sequentially(' final', delay=5)
expect(heading(page)).to_have_text('Delayed title while typing final', timeout=20000)
expect(heading(page, 'services_list')).to_have_text('Services while waiting')
idle(page)
assert gate['max_active'] == 1, gate
assert (site / 'pages/index.md').read_bytes() == original
run['checks'].append('two_second_delay_typing_selection_and_edits_across_sections')
tree(page, 'services_list')
number = page.locator('[data-inspector] [name="p.source.limit"]')
number.fill('invalid number')
expect(page.locator('#request-error')).to_be_visible()
expect(number).to_have_value('invalid number')
before = len(posts)
page.locator('[data-save-document]').click()
page.wait_for_timeout(350)
assert not any(p.endswith('/save') for p in posts[before:])
number.fill('3')
idle(page)
run['checks'].append('validation_preserves_input_and_blocks_save_until_fixed')
tree(page, 'hero_home')
with patch.object(PreviewStore, 'render_document', side_effect=OSError('QA preview failure')):
title(page).fill('Accepted despite preview failure')
expect(page.locator('#request-error [data-request-error-details]')).to_contain_text('preview_failed')
expect(page.locator('#document-source')).to_have_value(re.compile('Accepted despite preview failure'))
expect(heading(page)).to_have_text('Delayed title while typing final')
title(page).fill('Preview recovered')
expect(heading(page)).to_have_text('Preview recovered')
idle(page)
run['checks'].append('preview_failure_retains_accepted_edit_and_old_preview')
def disconnect(route):
route.abort('failed')
page.route('**/admin/editor/pages/index/update', disconnect, times=1)
title(page).fill('Offline edit')
expect(page.locator('#request-error [data-request-error-details]')).to_contain_text('network_error')
expect(title(page)).to_have_value('Offline edit')
page.unroute('**/admin/editor/pages/index/update', disconnect)
title(page).fill('Reconnected edit')
idle(page)
expect(heading(page)).to_have_text('Reconnected edit')
run['checks'].append('network_failure_preserves_input_and_recovers')
gate['delay'] = 1
gate['save_delay'] = 1.5
title(page).fill('Saved captured revision')
page.wait_for_function("()=>document.getElementById('document-editor').dataset.updating==='true'")
page.locator('[data-save-document]').click()
for _ in range(200):
if gate['saving']:
break
page.wait_for_timeout(20)
assert gate['saving']
title(page).fill('New edit during save')
page.wait_for_function("()=>document.getElementById('buffer-status').textContent.includes('несохранённые')")
expect(heading(page)).to_have_text('New edit during save', timeout=20000)
idle(page)
assert 'Saved captured revision' in (site / 'pages/index.md').read_text()
assert 'New edit during save' not in (site / 'pages/index.md').read_text()
expect(page.locator('#buffer-status')).to_have_text('Есть несохранённые правки')
gate['save_delay'] = 0
page.locator('[data-save-document]').click()
expect(page.locator('#buffer-status')).to_have_text('Нет несохранённых изменений')
run['checks'].append('save_drains_updates_and_keeps_newer_input_unsaved')
second = context.new_page()
second.goto(admin + '/admin/pages/index')
idle(second)
title(page).fill('Saved from first tab')
page.locator('[data-save-document]').click()
expect(page.locator('#buffer-status')).to_have_text('Нет несохранённых изменений')
title(second).fill('Conflicting second tab')
second.locator('[data-save-document]').click()
dialog = second.locator('[data-conflict-dialog]')
expect(dialog).to_be_visible()
expect(title(second)).to_have_value('Conflicting second tab')
dialog.locator('input[type=checkbox]').check()
dialog.locator('[data-accept-base]').click()
second.locator('[data-save-document]').click()
expect(second.locator('#buffer-status')).to_have_text('Нет несохранённых изменений')
assert 'Conflicting second tab' in (site / 'pages/index.md').read_text()
second.close()
run['checks'].append('real_two_tab_conflict_and_explicit_rebase')
page.get_by_role('button', name='Эксперт', exact=True).click()
source = page.locator('#document-source')
expect(source).to_be_visible()
source.fill(source.input_value() + '\nQA expert body\n')
idle(page)
page.get_by_role('button', name='Конструктор', exact=True).click()
expect(title(page)).to_be_visible()
page.get_by_role('button', name='Эксперт', exact=True).click()
expect(source).to_be_visible()
before = source.input_value()
source.fill('---\ntitle: [broken\n---\n')
page.wait_for_timeout(650)
expect(page.locator('#document-editor')).to_have_attribute('data-mode', 'expert')
expect(source).to_have_value('---\ntitle: [broken\n---\n')
source.fill(before)
idle(page)
page.get_by_role('button', name='Конструктор', exact=True).click()
run['checks'].append('expert_roundtrip_and_invalid_yaml_recovery')
if page.locator('#request-error').is_visible():
page.locator('[data-close-request-error]').click()
page.locator('[data-catalog-open]').first.click()
page.locator('#builder-catalog-dialog [data-fragment=richtext]').click()
idle(page)
selected = page.locator('[data-tree-scope=page].selected').get_attribute('data-tree-id')
assert re.fullmatch(r'richtext_[a-z0-9]{5}', selected), selected
page.locator('#inspectpane button[name=operation][value=duplicate]').click()
idle(page)
duplicate = page.locator('[data-tree-scope=page].selected').get_attribute('data-tree-id')
assert duplicate != selected
page.locator('#inspectpane button[name=operation][value=delete]').click()
page.locator('#builder-confirm-dialog [data-builder-confirm]').click()
idle(page)
assert page.locator(f'[data-tree-id="{duplicate}"]').count() == 0
run['checks'].append('catalog_duplicate_delete_with_designer_dialog')
page.locator('[data-builder-reset]').click()
page.locator('#builder-confirm-dialog [data-builder-confirm]').click()
idle(page)
page.set_viewport_size({"width": 390, "height": 844})
page.locator('[data-viewport=mobile]').click()
assert not page.evaluate('document.documentElement.scrollWidth>innerWidth+1')
page.screenshot(path=str(out / f"builder-{'bridge' if interactive else 'passive'}-390.png"), full_page=True)
page.set_viewport_size({"width": 1440, "height": 1050})
page.screenshot(path=str(out / f"builder-{'bridge' if interactive else 'passive'}-1440.png"), full_page=True)
run['checks'].append('reset_mobile_layout_and_screenshots')
page.goto(admin + '/admin/content/services/bots')
idle(page)
entry = page.locator('[data-inspector] [name="p.title"]')
entry.fill('Entry background update')
idle(page)
expect(page.frame_locator('#preview-result iframe').locator('h1')).to_have_text('Entry background update')
expect(entry).to_have_value('Entry background update')
run['checks'].append('entry_inspector_background_update')
assert not any(p.endswith(('/transform', '/preview')) for p in posts), posts
run['max_concurrent_updates'] = gate['max_active']
run['posts'] = len(posts)
print(json.dumps(run, ensure_ascii=False), flush=True)
browser.close()
assert not report['page_errors'], report['page_errors']
assert not report['native_dialogs'], report['native_dialogs']
(out / 'browser.json').write_text(json.dumps(report, ensure_ascii=False, indent=2))
print(out / 'browser.json')
if __name__ == '__main__':
main()